Log condition report for child management context#50378
Closed
zxuhan wants to merge 1 commit into
Closed
Conversation
Register a ConditionEvaluationReportLoggingListener on the management context created when management.server.port differs from server.port. Without this, conditions evaluated in the child context are absent from the auto-configuration report logged at startup. See spring-projectsgh-6698 Signed-off-by: zxuhan7 <zxuhan7@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
Member
|
Unfortunately, this doesn't feel like the right approach as I don't think the code that creates the management context should know about the |
wilkinsona
added
status: declined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
management.server.portdiffers fromserver.port, Spring Boot creates a child management context with its own conditions. TheConditionEvaluationReportLoggingListenerregistered viaspring.factoriesonly attaches to the parent context, so the child's conditions are absent from the report logged at startup.This change registers a
ConditionEvaluationReportLoggingListeneron the management context as part ofChildManagementContextInitializer.createManagementContext, so the child's conditions are logged alongside the parent's.See gh-6698